Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snaps): Fix gaps for custom UI Boxes #27405

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(snaps): Fix gaps for custom UI Boxes #27405

merged 1 commit into from
Sep 25, 2024
+3 −2

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Sep 25, 2024 •
edited by github-actions bot
Loading

Description

This PR fixes the gap between boxes being always at 16px.

It's now set to 16px for the root Box and 8px for all the children Boxes

Open in GitHub Codespaces

Related issues

Fixes: #27399

Manual testing steps

  1. Go to test-snaps
  2. Use the send flow example snap
  3. The higher box should have a 16px gap and the other one should have a 8px gap

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner September 25, 2024 17:57
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 25, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [bc04907]
Page Load Metrics (1900 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint157526841899271130
domContentLoaded154822831830211102
load156527901900282135
domInteractive16197614421
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GuillaumeRx GuillaumeRx merged commit ad7a546 into develop Sep 25, 2024
81 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/fix-custom-ui branch September 25, 2024 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
@metamaskbot metamaskbot added release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmalik88 hmalik88 hmalik88 approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-snaps-platform Snaps Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix gap in snap UI renderer
4 participants
@GuillaumeRx @metamaskbot @Mrtenz @hmalik88